Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Spark: Add _row_id and _last_updated_sequence_number readers #12836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 21, 2025
Merged

Spark: Add _row_id and _last_updated_sequence_number readers #12836

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3064389
Core: Always project manifest first_row_id.
rdblue Apr 18, 2025
c9a4537
Spark 3.5: Implement _row_id reader.
rdblue Apr 17, 2025
48bee89
Spark: Implement last updated seq reader.
rdblue Apr 18, 2025
492259d
Remove unnecessary DL logic for constants.
rdblue Apr 18, 2025
4ae7dbd
Reduce complexity of struct method in read builders.
rdblue Apr 18, 2025
e4bda01
Fix revapi.
rdblue Apr 18, 2025
42aaf26
Fix Flink tests.
rdblue Apr 18, 2025
4b5e013
Use position reader rather than duplicating.
rdblue Apr 18, 2025
47f9ee7
Fix revapi.
rdblue Apr 18, 2025
fc02040
Fix position reader use.
rdblue Apr 18, 2025
a18b51f
Spark: Add basic row lineage test.
rdblue Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Spark: Add basic row lineage test.
  • Loading branch information
@rdblue
rdblue committed Apr 18, 2025
commit a18b51f2966a1df84084a475a2a056d9eb1d783b
5 changes: 4 additions & 1 deletion spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,10 @@ private boolean useCometBatchReads() {
}

private boolean supportsCometBatchReads(Types.NestedField field) {
return field.type().isPrimitiveType() && !field.type().typeId().equals(Type.TypeID.UUID);
return field.type().isPrimitiveType()
&& !field.type().typeId().equals(Type.TypeID.UUID)
&& field.fieldId() != MetadataColumns.ROW_ID.fieldId()
&& field.fieldId() != MetadataColumns.LAST_UPDATED_SEQUENCE_NUMBER.fieldId();
}

// conditions for using ORC batch reads:
Expand Down
9 changes: 4 additions & 5 deletions spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/SparkTestHelperBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,7 @@ protected void assertEquals(
Object[] expected = expectedRows.get(row);
Object[] actual = actualRows.get(row);
assertThat(actual).as("Number of columns should match").hasSameSizeAs(expected);
for (int col = 0; col < actualRows.get(row).length; col += 1) {
String newContext = String.format("%s: row %d col %d", context, row + 1, col + 1);
assertEquals(newContext, expected, actual);
}
assertEquals(context + ": row " + (row + 1), expected, actual);
}
}

Expand All @@ -83,7 +80,9 @@ protected void assertEquals(String context, Object[] expectedRow, Object[] actua
assertEquals(newContext, (Object[]) expectedValue, (Object[]) actualValue);
}
} else if (expectedValue != ANY) {
assertThat(actualValue).as(context + " contents should match").isEqualTo(expectedValue);
assertThat(actualValue)
.as(context + " col " + (col + 1) + " contents should match")
.isEqualTo(expectedValue);
}
}
}
Expand Down