update links to daft docs #12860
Merged
update links to daft docs #12860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did a major refresh of Daft docs on our end, so want to make sure the links are also updated on your end! One thing to note: On our docs, we renamed the below fields, let me know if it makes sense to update these as well: | Iceberg | Daft | | struct(**fields) | daft.DataType.struct(**fields) | | list(child_type) | daft.DataType.list(child_type) | | map(K, V) | daft.DataType.map(K, V) |
ebyhr
approved these changes
Apr 22, 2025
| | `struct(**fields)` | [`daft.DataType.struct(**fields)`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.struct) | | ||
| | `list(child_type)` | [`daft.DataType.list(child_type)`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.list) | | ||
| | `map(K, V)` | [`daft.DataType.map(K, V)`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.map) | | ||
| | `struct(**fields)` | [`daft.DataType.struct(**fields)`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.struct) | |
There was a problem hiding this comment.
Why does fields contain leading **? Is it for Python or Rust syntax?
There was a problem hiding this comment.
RussellSpitzer
approved these changes
Apr 22, 2025
|
Thanks @ccmao1130 for the PR and @ebyhr for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did a major refresh of Daft docs on our end, so want to make sure the links are also updated on your end!
One thing to note:
On our docs, we renamed the below fields, let me know if it makes sense to update these as well:
Here's our page for reference: https://www.getdaft.io/projects/docs/en/latest/integrations/iceberg/