Arrow, AWS, Azure, Core, GCP, Hive, Kafka, Snowflake: Rename test classes to use Test as prefix instead of suffix #12879
Conversation
| import software.amazon.awssdk.services.s3.S3Client; | ||
| import software.amazon.awssdk.services.s3.S3ClientBuilder; | ||
|
|
||
| public class HttpClientPropertiesTest { |
There was a problem hiding this comment.
this was a duplicate and the exact same tests under TestHttpClientProperties already exist
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
…sses to use Test as prefix instead of suffix It appears that we have some tests that use `Test` as a suffix in the test class name, while all other modules use it in their prefix.
6122d01 to
665626f
Compare
|
@stevenzwu @pvary @RussellSpitzer @amogh-jahagirdar would be good to get your opinions on this minor renaming of test classes |
|
This is pretty low on my list of annoying things about the tests, 👀 @ test template, but I have no problem if we want to standardize. |
There was a problem hiding this comment.
Thanks @nastra good to clean this up. Curious do you know off the top of your head if there's a way to lint/checkstyle this naming pattern (I can research myself just curious)? Reason I ask is, I can easily see myself forgetting about this and losing the convention later on.
I've opened #13442 to address this. Maybe somebody in the community is interested in picking this up, because I couldn't produce sufficient results for that check |
It appears that we have some tests that use
Testas a suffix in the test class name, while all other modules use it in their prefix.