Flink: Add lockFactory open in LockRemover for table maintenance #12900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
823fa50 to
f49467a
Compare
pvary
reviewed
Apr 29, 2025
.../v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockRemover.java
Show resolved
Hide resolved
pvary
reviewed
Apr 29, 2025
.../v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockRemover.java
Show resolved
Hide resolved
pvary
approved these changes
Apr 29, 2025
|
@pvary Thanks for the review ! I will prepare the backport to the other version later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LockRemover, I noticed we missed
lockFactory.open()beforethis.lock = lockFactory.createLock(). This could lead to an NPE since the factory isn't initialized and we have to close lock after (similar to the pool in jdbcFactory).This pr is aim to add the init of lockFactory when LockRemover init.