Spec: Remove misleading statement about source-ids #12948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
approved these changes
May 1, 2025
Fokko
approved these changes
May 1, 2025
|
That's correct: source-id and source-ids are exclusive. |
RussellSpitzer
approved these changes
May 1, 2025
|
Merging this because we already voted on this in general and this is essentially just a typo we forgot to remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12644, the spec was clarified that for a partition field,
source-idshould always be written if has a single-argument transform, andsource-idsshould be written instead if it has a multi-argument transform.There is a statement left over that conflicts with the above. In this PR, we remove that statement.