Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sfc-gh-bhannel
Copy link
Contributor

@sfc-gh-bhannel sfc-gh-bhannel commented May 6, 2025

This PR addresses #12943

Every other transform has 2 public overloads: one that takes a targetName, and one that does not. The one exception is identity, where the overload with targetName is not public. This looks like an oversight. This functionality is needed to support partition transforms with renamed source columns correctly.

Concretely, here is a use case where this is necessary:

  • Engine A: CREATE TABLE t (col1 int) PARTITION BY (col1) -> creates a transform called col1
  • Engine A: ALTER TABLE t RENAME col1 TO col2 -> transform is still called col1
  • Engine B: Tries to read or write t. At this point Engine B must be able to create a transform called col1 which has col2 as the source in order to accurately reflect Iceberg metadata.

@github-actions github-actions bot added the API label May 6, 2025
@RussellSpitzer RussellSpitzer merged commit 3469cf3 into apache:main May 29, 2025
43 checks passed
@RussellSpitzer
Copy link
Member

Thanks @sfc-gh-bhannel for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants