Make PartitionSpec.Builder::identity public #12975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #12943
Every other transform has 2 public overloads: one that takes a targetName, and one that does not. The one exception is identity, where the overload with targetName is not public. This looks like an oversight. This functionality is needed to support partition transforms with renamed source columns correctly.
Concretely, here is a use case where this is necessary:
CREATE TABLE t (col1 int) PARTITION BY (col1)
-> creates a transform called col1ALTER TABLE t RENAME col1 TO col2
-> transform is still called col1t
. At this point Engine B must be able to create a transform called col1 which has col2 as the source in order to accurately reflect Iceberg metadata.