Spec: Update v3 summary, add row lineage #12982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format/spec.md
Outdated
| @@ -1680,6 +1680,23 @@ Row-level delete changes: | |||
| * These position delete files must be merged into the DV for a data file when one is created | |||
| * Position delete files that contain deletes for more than one data file need to be kept in table metadata until all deletes are replaced by DVs | |||
|
|
|||
| Row lineage changes: | |||
|
|
|||
| * Writers must set the table's `next-row-id` and use the existing `next-row-id` as the `first-row-id` to create a new snapshot | |||
There was a problem hiding this comment.
Suggested change
| * Writers must set the table's `next-row-id` and use the existing `next-row-id` as the `first-row-id` to create a new snapshot | |
| * Writers must set the table's `next-row-id` and use the existing `next-row-id` as the `first-row-id` when creating new snapshots |
There was a problem hiding this comment.
I considered this language, but I think it's more clear to use a singular snapshot. I don't want to imply that you would use next-row-id for multiple snapshots.
There was a problem hiding this comment.
I'm 60:40 on my version versus yours so not a huge deal if you don't want to change it
There was a problem hiding this comment.
You're right. I committed this change. I think I'm just being pedantic.
Co-authored-by: Russell Spitzer <[email protected]>
RussellSpitzer
approved these changes
May 7, 2025
|
Thanks @rdblue for the important info, merged since this is just a restatement of information elsewhere in the spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a summary of row lineage changes to the section on v3 changes.