-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Kafka Connect: Add BigQuery Metastore catalog #13041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka Connect: Add BigQuery Metastore catalog #13041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me although I can't speak to the correctness, I do think we have added some duplicates into the build script and those should get cleaned up
I removed them |
7a15c47
to
13c3635
Compare
@juldrixx Do you test with Bigquery ? If not I can give a try. LGTM for me too! Thank you for this PR. |
@talatuyarer I did tried it and we can say that it works as intended. Thank you for your PR 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RussellSpitzer Is it also good for you? (I think It has to be you, to approve the workflows and merge the PR) |
Thanks @juldrixx for the pr! Thanks @talatuyarer for reviewing! |
As the BigQuery Metastore catalog was introduced in #12808, this PR aims to make it available in the Kafka Connect.