Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

juldrixx
Copy link
Contributor

As the BigQuery Metastore catalog was introduced in #12808, this PR aims to make it available in the Kafka Connect.

Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me although I can't speak to the correctness, I do think we have added some duplicates into the build script and those should get cleaned up

@juldrixx
Copy link
Contributor Author

This looks good to me although I can't speak to the correctness, I do think we have added some duplicates into the build script and those should get cleaned up

I removed them

@juldrixx juldrixx force-pushed the kafka_connect/add_bigquery_metastore_catalog branch from 7a15c47 to 13c3635 Compare May 14, 2025 21:00
@talatuyarer
Copy link
Contributor

@juldrixx Do you test with Bigquery ? If not I can give a try. LGTM for me too! Thank you for this PR.

@juldrixx
Copy link
Contributor Author

juldrixx commented May 15, 2025

@talatuyarer I did tried it and we can say that it works as intended. Thank you for your PR 😄

Copy link
Contributor

@talatuyarer talatuyarer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juldrixx
Copy link
Contributor Author

@RussellSpitzer Is it also good for you? (I think It has to be you, to approve the workflows and merge the PR)

@RussellSpitzer
Copy link
Member

Thanks @juldrixx for the pr! Thanks @talatuyarer for reviewing!

@RussellSpitzer RussellSpitzer merged commit acffd4d into apache:main May 16, 2025
14 checks passed
@juldrixx juldrixx deleted the kafka_connect/add_bigquery_metastore_catalog branch May 16, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants