Spark 4.0: Row Lineage support #13310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java
Outdated
Show resolved
Hide resolved
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java
Show resolved
Hide resolved
7dcb5a2 to
be78ef5
Compare
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java
Outdated
Show resolved
Hide resolved
54145af to
3a6d7fa
Compare
...sions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
commented
Jul 7, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
commented
Jul 7, 2025
...ons/src/test/java/org/apache/iceberg/spark/extensions/TestRowLevelOperationsWithLineage.java
Outdated
Show resolved
Hide resolved
stevenzwu
reviewed
Jul 8, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java
Show resolved
Hide resolved
.../v4.0/spark/src/main/java/org/apache/iceberg/spark/source/ExtractRowLineageFromMetadata.java
Outdated
Show resolved
Hide resolved
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java
Outdated
Show resolved
Hide resolved
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java
Outdated
Show resolved
Hide resolved
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkMetadataColumn.java
Show resolved
Hide resolved
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jul 8, 2025
...sions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java
Outdated
Show resolved
Hide resolved
| public void beforeEach() { | ||
| assumeThat(formatVersion).isGreaterThanOrEqualTo(3); | ||
| // ToDo: Remove these as row lineage inheritance gets implemented in the other readers | ||
| assumeThat(fileFormat).isEqualTo(FileFormat.PARQUET); |
There was a problem hiding this comment.
maybe worth overriding parameters() in TestRowLevelOperationsWithLineage and defining a smaller test matrix, wdyt?
There was a problem hiding this comment.
Yup agreed! I need to rebase and incorporate hte latest test changes I made which define a smaller test matrix (and will also remove the changes I made to SparkRowLevelOperationsTestBase)
...ons/src/test/java/org/apache/iceberg/spark/extensions/TestRowLevelOperationsWithLineage.java
Outdated
Show resolved
Hide resolved
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkMetadataColumn.java
Show resolved
Hide resolved
| public NamedReference[] requiredMetadataAttributes() { | ||
| NamedReference specId = Expressions.column(MetadataColumns.SPEC_ID.name()); | ||
| NamedReference partition = Expressions.column(MetadataColumns.PARTITION_COLUMN_NAME); | ||
| if (TableUtil.supportsRowLineage(table)) { |
There was a problem hiding this comment.
nit: I'm fine either way but I think it would be could to align how this is done here (stores named references in an array) vs in SparkCopyOnWriteOperation (which stores named references in a list)
| .writeProperties(writeProperties) | ||
| .build(); | ||
|
|
||
| Function<InternalRow, InternalRow> extractRowLineage = |
There was a problem hiding this comment.
nit: maybe rowLineageExtractor or something along those lines? I only mention this because extractRowLineage sounds like a boolean flag
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java
Show resolved
Hide resolved
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java
Outdated
Show resolved
Hide resolved
b5c5dd6 to
0d51fb5
Compare
stevenzwu
reviewed
Jul 8, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java
Show resolved
Hide resolved
stevenzwu
reviewed
Jul 8, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
Show resolved
Hide resolved
amogh-jahagirdar
commented
Jul 8, 2025
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkAvroReader.java
Show resolved
Hide resolved
dad59a1 to
31cfce2
Compare
…stently for surfacing metadata columns, and include test refactorings that were done in 3.4/3.5
…isting metadata row
31cfce2 to
2eb84ca
Compare
stevenzwu
reviewed
Jul 10, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java
Outdated
Show resolved
Hide resolved
…mMetadata to RowLineageExtractor
stevenzwu
reviewed
Jul 14, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/ExtractRowLineage.java
Outdated
Show resolved
Hide resolved
stevenzwu
reviewed
Jul 14, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/ExtractRowLineage.java
Outdated
Show resolved
Hide resolved
stevenzwu
reviewed
Jul 14, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/ExtractRowLineage.java
Show resolved
Hide resolved
stevenzwu
reviewed
Jul 14, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/ExtractRowLineage.java
Outdated
Show resolved
Hide resolved
stevenzwu
reviewed
Jul 14, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java
Outdated
Show resolved
Hide resolved
stevenzwu
reviewed
Jul 14, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java
Show resolved
Hide resolved
stevenzwu
reviewed
Jul 14, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java
Show resolved
Hide resolved
…ow lineage decoration
stevenzwu
reviewed
Jul 14, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/ExtractRowLineage.java
Outdated
Show resolved
Hide resolved
stevenzwu
reviewed
Jul 14, 2025
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/ExtractRowLineage.java
Outdated
Show resolved
Hide resolved
stevenzwu
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements spark 4.0 with Iceberg v3's row lineage feature; this approach uses the new conditional nullification mechanism introduced in 4.0 instead of custom rules that we implemented for 3.5