Test: Simplify collection and optional assertions #13613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29b146c to
010dfc8
Compare
nastra
reviewed
Jul 21, 2025
|
|
||
| assertThat(cache.size()).isEqualTo(1); | ||
| assertThat(cache).containsExactlyEntriesOf(Map.of(1, 1)); | ||
| assertThat(cache).hasSize(1).containsExactlyEntriesOf(Map.of(1, 1)); |
There was a problem hiding this comment.
Suggested change
| assertThat(cache).hasSize(1).containsExactlyEntriesOf(Map.of(1, 1)); | |
| assertThat(cache).hasSize(1).containsEntry(1, 1); |
nastra
reviewed
Jul 21, 2025
|
|
||
| assertThat(cache.size()).isEqualTo(2); | ||
| assertThat(cache).containsExactly(Map.entry(1, 1), Map.entry(3, 3)); | ||
| assertThat(cache).hasSize(2).containsExactly(Map.entry(1, 1), Map.entry(3, 3)); |
There was a problem hiding this comment.
Suggested change
| assertThat(cache).hasSize(2).containsExactly(Map.entry(1, 1), Map.entry(3, 3)); | |
| assertThat(cache).hasSize(2).containsEntry(1, 1).containsEntry(3, 3); |
nastra
reviewed
Jul 21, 2025
| double maxDriftPercentage) { | ||
|
|
||
| assertThat(partitionResults.size()).isEqualTo(expectedAssignmentInfo.size()); | ||
| assertThat(partitionResults).hasSize(expectedAssignmentInfo.size()); |
There was a problem hiding this comment.
Suggested change
| assertThat(partitionResults).hasSize(expectedAssignmentInfo.size()); | |
| assertThat(partitionResults).hasSameSizeAs(expectedAssignmentInfo); |
nastra
reviewed
Jul 21, 2025
| FlinkParquetReaders.buildReader(new Schema(SUPPORTED_PRIMITIVES.fields()), fileSchema); | ||
|
|
||
| assertThat(reader.columns().size()).isEqualTo(SUPPORTED_PRIMITIVES.fields().size()); | ||
| assertThat(reader.columns()).hasSize(SUPPORTED_PRIMITIVES.fields().size()); |
There was a problem hiding this comment.
Suggested change
| assertThat(reader.columns()).hasSize(SUPPORTED_PRIMITIVES.fields().size()); | |
| assertThat(reader.columns()).hasSameSizeAs(SUPPORTED_PRIMITIVES.fields()); |
nastra
reviewed
Jul 21, 2025
|
|
||
| assertThat(cache.size()).isEqualTo(1); | ||
| assertThat(cache).containsExactlyEntriesOf(Map.of(1, 1)); | ||
| assertThat(cache).hasSize(1).containsExactlyEntriesOf(Map.of(1, 1)); |
nastra
reviewed
Jul 21, 2025
|
|
||
| // verify that the dataframe matches | ||
| assertThat(rows.size()).isEqualTo(records.size()); | ||
| assertThat(rows).hasSize(records.size()); |
There was a problem hiding this comment.
Suggested change
| assertThat(rows).hasSize(records.size()); | |
| assertThat(rows).hasSameSizeAs(records); |
the advantage here is that this will also show the content of actual/expected when the assertion ever fails
There was a problem hiding this comment.
can you also please update all the other places that are affected in this PR?
There was a problem hiding this comment.
Thanks for your suggestion. Addressed comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.