Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Build, Flink: Add timeout and print more logs #13627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Build, Flink: Add timeout and print more logs #13627

merged 2 commits into from
Jul 23, 2025

Conversation

pvary
Copy link
Contributor

@pvary pvary commented Jul 22, 2025

I often face a situation where the Flink test is stuck in an infinite loop.
Last time it happened with TestFlinkUpsert.

This PR adds the timeout to the test, and also adds stop/start logs to the CI output, so it is easier to find the stuck tests.

nastra
nastra reviewed Jul 22, 2025
View reviewed changes
build.gradle Outdated

testLogging {
events "failed"
events "started", "passed", "skipped", "failed"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that #1210 added more output logging, which was immediately reverted by #1212, so we might be a little cautious with having too much output

nastra
nastra approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would be cautious with having too much logging output now. Maybe we can try this for a week and see if it adds too much noise or not

@pvary
Copy link
Contributor Author

pvary commented Jul 23, 2025

LGTM, but I would be cautious with having too much logging output now. Maybe we can try this for a week and see if it adds too much noise or not

Added a CI check before the config change, so user builds are not affected:

      // Check if running on CI environment
      if (System.getenv('CI') != null) {
        // More verbose logging for CI environments
        events "started", "passed", "skipped", "failed"
      } else {
        events "failed"
      }

@pvary pvary merged commit 39e8568 into apache:main Jul 23, 2025
43 checks passed
@pvary
Copy link
Contributor Author

pvary commented Jul 23, 2025

Merged to main.
Thanks for the review @nastra, @Guosmilesmile, @mxm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastra nastra nastra approved these changes

+2 more reviewers

@mxm mxm mxm approved these changes

@Guosmilesmile Guosmilesmile Guosmilesmile approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
build flink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pvary @nastra @mxm @Guosmilesmile