Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Core: Remove redundant V2TableTestBase #13757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Core: Remove redundant V2TableTestBase #13757

merged 1 commit into from
Aug 7, 2025
+0 −29

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Aug 7, 2025

V2 is covered by TestBase in my understanding.

iceberg/core/src/test/java/org/apache/iceberg/TestBase.java

Lines 201 to 204 in aca9775

@Parameters(name = "formatVersion = {0}")
protected static List<Integer> formatVersions() {
return ALL_VERSIONS;
}

Also, the test class wasn't runnable at least in my IDE.
Screenshot 2025-08-07 at 20 31 01

@github-actions github-actions bot added the core label Aug 7, 2025
hsiang-c
hsiang-c approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@hsiang-c hsiang-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nastra nastra merged commit 6eeb924 into apache:main Aug 7, 2025
42 checks passed
@ebyhr ebyhr deleted the ebi/test-v2 branch August 7, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastra nastra nastra approved these changes

+1 more reviewer

@hsiang-c hsiang-c hsiang-c approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebyhr @nastra @hsiang-c