[WIP]optimize : change transaction state thread-safe in db mode #4383

Bughue · 2022-02-16T03:56:11Z

Ⅰ. Describe what this PR did

更新globalstatus的时候采用线程安全的方式，阻止预期状态不匹配的操作继续执行。
目前的思路是：rollback和commit都用乐观锁方式去更新globalsession的status，更新成功的会往下执行。没有更新成功的会遇到异常而中断。
传参expected status方式使用threadlocal

以下两个pr优化了之后，这个pr可以简化
#4858
#4881

pr已经重新提交
#5501

Ⅱ. Does this pull request fix one issue?

fixes #4372

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

server/src/main/java/io/seata/server/storage/db/session/DataBaseSessionManager.java

server/src/main/java/io/seata/server/coordinator/DefaultCore.java

server/src/main/java/io/seata/server/storage/redis/session/RedisSessionManager.java

server/src/main/java/io/seata/server/session/GlobalSession.java

server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java

server/src/main/java/io/seata/server/session/AbstractSessionManager.java

server/src/main/java/io/seata/server/session/GlobalSession.java

server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java

server/src/main/java/io/seata/server/session/GlobalSession.java

server/src/main/java/io/seata/server/storage/db/session/DataBaseSessionManager.java

…pache#5413) Signed-off-by: slievrly <[email protected]>

Signed-off-by: slievrly <[email protected]>

…ailureHandler (apache#5415) Signed-off-by: slievrly <[email protected]>

…apache#5402)

funky-eyes · 2023-03-21T12:25:48Z

server/src/main/java/io/seata/server/coordinator/DefaultCore.java

            if (globalSession.getStatus() == GlobalStatus.Begin) {
                // Highlight: Firstly, close the session, then no more branch can be registered.
-                globalSession.closeAndClean();
+                globalSession.close();


Why change to close,instead of closeAndClean

close session first, and clean it later (line172)

我想起来了，是防止一下解锁了后，事务状态不一致了？因为现在是先close后解锁，如果这个时候先解锁更新状态失败了，说明这个事务timeoutcheck线程改成回滚了，但是由于先解锁会可能数据被脏写@slievrly 看下这个情况，由于先改状态后解锁，性能肯定是会受到一定影响

slievrly · 2023-03-28T05:37:48Z

server/src/main/java/io/seata/server/storage/db/session/DataBaseSessionManager.java

-            throw new StoreException("updateGlobalSessionStatus failed.");
+        try {
+            //  set expected status threadlocal
+            session.setExpectedStatusFromCurrent();


Using threadlocal on the server side is not a good design solution.It is tied to the current threading model. threadlocal's public set method does nothing to protect it from abuse.

在server侧使用threadlocal不是一个好的设计方案，这里与当前的线程处理模型有绑定关系。threadlocal 的public set方法没办法去规避被滥用的风险。

slievrly · 2023-03-28T06:42:19Z

server/src/main/java/io/seata/server/storage/db/store/LogStoreDataBaseDAO.java

+            conn = logStoreDataSource.getConnection();
+            conn.setAutoCommit(true);
+            ps = conn.prepareStatement(sql);
+            ps.setInt(index++, globalTransactionDO.getStatus());


Specify the index order of the columns rather than relying on the order of the code.

明确列的index顺序而不要依赖代码的顺序。

我是为了遵循本来的风格，所以趁这次把这个方法改掉吗？

…ception thrown (apache#5472)

funky-eyes

LGTM

� Conflicts: � .github/workflows/build.yml � .github/workflows/publishes.yml � .github/workflows/test.yml � changes/en-us/develop.md � changes/zh-cn/develop.md � integration-tx-api/src/main/java/io/seata/integration/tx/api/interceptor/handler/GlobalTransactionalInterceptorHandler.java � rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java � rm-datasource/src/main/java/io/seata/rm/datasource/undo/mysql/MySQLUndoUpdateExecutor.java � server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java

Bughue added 6 commits February 14, 2022 18:58

check time out thread-safe

e60015c

checkTimeOut/commit thread-safe

0e76b9a

checkTimeOut/commit thread-safe test

2830c1b

rollback thread-safe and test

8075602

add comment

db301ed

add comment

bfae00f

slievrly added the first-time contributor first-time contributor label Feb 16, 2022

slievrly and others added 7 commits February 16, 2022 15:15

Merge branch 'develop' into develop

cfb1fc8

check style

af7ea69

Merge remote-tracking branch 'origin/develop' into develop

24bc0b3

check style

23cd1e6

Merge branch 'develop' into develop

ac7f0d2

check style

58ebeba

Merge remote-tracking branch 'origin/develop' into develop

9460259

Bughue changed the title ~~change transaction state thread-safe in db/redis mode~~ bugfix:change transaction state thread-safe in db/redis mode Feb 17, 2022

Bughue changed the title ~~bugfix:change transaction state thread-safe in db/redis mode~~ optimize : change transaction state thread-safe in db/redis mode Feb 17, 2022

pengten reviewed Feb 17, 2022

View reviewed changes

server/src/main/java/io/seata/server/storage/db/session/DataBaseSessionManager.java Outdated Show resolved Hide resolved

pengten reviewed Feb 17, 2022

View reviewed changes

server/src/main/java/io/seata/server/coordinator/DefaultCore.java Outdated Show resolved Hide resolved

pengten reviewed Feb 17, 2022

View reviewed changes

server/src/main/java/io/seata/server/storage/redis/session/RedisSessionManager.java Outdated Show resolved Hide resolved

Bughue added 2 commits February 18, 2022 10:28

clean session after changing status

92c133c

changes report

712eeb9

pengten approved these changes Feb 21, 2022

View reviewed changes

pengten previously approved these changes Feb 21, 2022

View reviewed changes

Merge branch 'develop' into develop

52300a9

funky-eyes reviewed Feb 23, 2022

View reviewed changes

server/src/main/java/io/seata/server/session/GlobalSession.java Outdated Show resolved Hide resolved

server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java Outdated Show resolved Hide resolved

funky-eyes and others added 2 commits February 23, 2022 11:33

Merge branch 'develop' into develop

01f900a

thread-safe update status & comment

af36d9b

funky-eyes reviewed Feb 23, 2022

View reviewed changes

server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java Outdated Show resolved Hide resolved

funky-eyes reviewed Feb 23, 2022

View reviewed changes

|| GlobalStatus.TimeoutRollbacking == targetStatus

d47dfe8

liuqiufeng and others added 10 commits February 12, 2023 22:05

bugfix: fix some tiny bugs (apache#5332)

04fac86

optimize: add tcc fence log clean task delay check (apache#5089)

357f8e8

optimize: add store mode,config type and registry type log info (apac…

b4f6fb7

…he#5325)

Merge branch '2.x' into develop

a662c25

bugfix: fix when TC returns RollbackFailed FailureHandler not executed (

97bad4b

apache#5321)

feature: support http put (apache#5070)

e0a02fb

test: fix UpdateExecutorTest failed (apache#5380)

9194aa0

test: fix multi spring version test failed (apache#5382)

85b2f34

optimize: unified project version (apache#5372)

00ca98c

bugfix : check if table meta cache should be refreshed in AT mode (ap…

28b3413

…ache#4734)

funky-eyes mentioned this pull request Mar 1, 2023

TC server DataBaseSessionManager.lockAndExecute 没有对 global session 加锁 #3619

Closed

wangliang181230 and others added 7 commits March 2, 2023 14:01

optimize: publish images based on java 8, 8-slim, 17, 17-slim (…

bb7e373

…apache#5168)

bugfix: fix bad service configuration file and compilation failure (a…

51f4b19

…pache#5413) Signed-off-by: slievrly <[email protected]>

optimize: optimize transaction fail handler (apache#5414)

d001af1

Signed-off-by: slievrly <[email protected]>

bugfix: fix transaction timeout on client side not execute hook and f…

ee0f744

…ailureHandler (apache#5415) Signed-off-by: slievrly <[email protected]>

optimize: upgrade easyj-maven-plugin to 1.1.5 for support maven 3.9.0 (…

98c17a5

…apache#5402)

Merge branch '2.x' into develop

a51caa1

bugfix: oracle xa mode cannnot be used By same database (apache#5447)

cdbc4c0

funky-eyes reviewed Mar 21, 2023

View reviewed changes

bugfix: global session is always begin in saga mode (apache#5145)

09bfc42

slievrly reviewed Mar 28, 2023

View reviewed changes

pengten and others added 2 commits March 29, 2023 12:02

bugfix: fix using @GlobalTransactional in provider ShouldNverHappenEx…

6162198

…ception thrown (apache#5472)

Merge branch '2.x' into develop

11b780a

funky-eyes approved these changes Apr 3, 2023

View reviewed changes

Bughue changed the title ~~optimize : change transaction state thread-safe in db mode~~ [WIP]optimize : change transaction state thread-safe in db mode Apr 10, 2023

Bughue closed this Apr 10, 2023

Bughue mentioned this pull request Apr 10, 2023

optimize : change transaction state thread-safe in db mode #5501

Merged

slievrly removed this from the 2.0.0 milestone Nov 14, 2023

[WIP]optimize : change transaction state thread-safe in db mode #4383

[WIP]optimize : change transaction state thread-safe in db mode #4383

Uh oh!

Conversation

Bughue commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

funky-eyes Mar 21, 2023

Choose a reason for hiding this comment

Uh oh!

Bughue Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

funky-eyes Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

slievrly Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

slievrly Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

Bughue Mar 29, 2023

Choose a reason for hiding this comment

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Bughue commented Feb 16, 2022 •

edited

Loading