optimize: the problem of type inconsistency caused by deserialization of BusinessActionContext #5017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erialization of BusinessActionContext
funky-eyes
reviewed
Oct 25, 2022
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
Please add test cases
Contributor
Author
|
get it |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5017 +/- ##
=============================================
+ Coverage 48.76% 48.79% +0.03%
- Complexity 4173 4195 +22
=============================================
Files 743 749 +6
Lines 26626 26685 +59
Branches 3327 3328 +1
=============================================
+ Hits 12984 13022 +38
- Misses 12241 12258 +17
- Partials 1401 1405 +4
|
…n TCC mode is changed from fastjson to jackson
|
|
funky-eyes
reviewed
Dec 22, 2022
| private ContextSerializerFactory() {} | ||
|
|
||
| // ContextSerializer cache | ||
| private static final ConcurrentMap<String, ContextSerializer> INSTANCES = new ConcurrentHashMap<>(); |
Contributor
There was a problem hiding this comment.
private static final Map<String, ContextSerializer> INSTANCES = new ConcurrentHashMap<>();
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zation of BusinessActionContext
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5011
fixes #5334
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews