bugfix: fix SQLServer-related SQL error when using database of SQLServer #6493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakeActionNow2019
added a commit
to TakeActionNow2019/incubator-seata
that referenced
this pull request
Apr 22, 2024
…atabase of SQLServer (apache#6493)
c69ec03 to
3e023b5
Compare
Contributor
Author
|
@funky-eyes As your wish, I have merged the first two issues and then created a separate PR for them. Please help me review and merge it. Thanks a bunch! |
Contributor
Author
|
From #6477 |
funky-eyes
reviewed
Apr 23, 2024
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
/home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/console/impl/db/GlobalLockDBServiceImpl.java:120:9: 'if' is not followed by whitespace. [WhitespaceAround]
funky-eyes
reviewed
Apr 23, 2024
common/src/main/java/org/apache/seata/common/util/PageUtil.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/seata/core/store/db/sql/distributed/lock/BaseDistributedLockSqlServer.java
Show resolved
Hide resolved
...main/java/org/apache/seata/core/store/db/sql/distributed/lock/DistributedLockSqlFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/seata/core/store/db/sql/lock/SqlServerLockStoreSql.java
Show resolved
Hide resolved
core/src/main/java/org/apache/seata/core/store/db/sql/log/SqlServerLogStoreSqls.java
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/console/impl/db/GlobalLockDBServiceImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/console/impl/db/GlobalSessionDBServiceImpl.java
Outdated
Show resolved
Hide resolved
TakeActionNow2019
added a commit
to TakeActionNow2019/incubator-seata
that referenced
this pull request
Apr 23, 2024
…atabase of SQLServer (apache#6493)
c97eff7 to
ea352db
Compare
Contributor
Author
|
@funky-eyes As your wish, I have fixed all issures mentioned above. Please help me review and merge it again! Thanks a million! |
funky-eyes
reviewed
Apr 24, 2024
...main/java/org/apache/seata/core/store/db/sql/distributed/lock/DistributedLockSqlFactory.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/seata/core/store/db/sql/distributed/lock/BaseDistributedLockSqlServer.java
Show resolved
Hide resolved
…atabase of SQLServer (apache#6493)
b2750fe to
5b322d9
Compare
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md # core/src/main/java/org/apache/seata/core/store/db/sql/lock/SqlServerLockStoreSql.java # script/server/db/sqlserver.sql
funky-eyes
reviewed
Apr 25, 2024
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
Please format the code blocks related to your changes to ensure that CI checks pass the code style validation
TakeActionNow2019
added a commit
to TakeActionNow2019/incubator-seata
that referenced
this pull request
Apr 25, 2024
…atabase of SQLServer (apache#6493)
ebdc745 to
e1d6a3e
Compare
…atabase of SQLServer (apache#6493)
e1d6a3e to
e232aee
Compare
Contributor
Author
Done! Please review again! Thank you so much! |
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.Fix the failure of seata server's starting because of SQL error in org.apache.seata.core.store.db.sql.lock.SqlServerLockStoreSql#INSERT_LOCK_SQL_SQLSERVER when using database SQLServer;
2.Fix the failure of querying TransactionInfo and GlobalLockInfo at seata server console when using database SQLServer;
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews