Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

upgrade elliptic to 6.5.7

Ⅱ. Does this pull request fix one issue?

https://github.com/apache/incubator-seata/security/dependabot/157
https://github.com/apache/incubator-seata/security/dependabot/156
https://github.com/apache/incubator-seata/security/dependabot/155

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.18%. Comparing base (256c4a3) to head (89820aa).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6787   +/-   ##
=========================================
  Coverage     52.17%   52.18%           
+ Complexity     6292     6291    -1     
=========================================
  Files          1065     1065           
  Lines         37199    37199           
  Branches       4413     4413           
=========================================
+ Hits          19410    19412    +2     
- Misses        15870    15871    +1     
+ Partials       1919     1916    -3     

see 2 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 27, 2024
@funky-eyes funky-eyes merged commit 4aa5d57 into apache:2.x Aug 27, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants