optimize: remove the branch registration operation of the XA read-only transaction #6826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and other related operations
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6826 +/- ##
============================================
+ Coverage 52.30% 52.34% +0.03%
- Complexity 6405 6421 +16
============================================
Files 1083 1083
Lines 37846 37916 +70
Branches 4489 4495 +6
============================================
+ Hits 19795 19846 +51
- Misses 16081 16097 +16
- Partials 1970 1973 +3
|
slievrly
reviewed
Sep 8, 2024
rm-datasource/src/main/java/org/apache/seata/rm/datasource/xa/ConnectionProxyXA.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n and other related operations
Ⅰ. Describe what this PR did
XA模式下。如果是只读事务就不注册分支及xa的任何操作
In XA mode, if it is a read-only transaction, the branch and any operation of xa will not be registered.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Manually set the connection's readOnly to true or set the annotation @transactional(readOnly = true) in the Spring framework
Ⅴ. Special notes for reviews