bugfix: SQLIntegrityConstraintViolationException capture incorrectly when inserting a globallock #6833

changeAtLater · 2024-09-09T03:49:14Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6822

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

funky-eyes

https://github.com/apache/incubator-seata/blob/2.x/changes/zh-cn/2.x.md
https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md
请在上述md文件中登记pr信息和作者信息
Please register pr information and author information in the above md file

server/src/main/java/org/apache/seata/server/storage/db/lock/LockStoreDataBaseDAO.java

funky-eyes · 2024-09-10T01:48:23Z

Caused by: java.sql.BatchUpdateException: Duplicate entry 'jdbc:mysql://127.0.0.1:3306/oa^^^sys_user_role^^^10000002_3' for key 'lock_table.PRIMARY'
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[na:1.8.0_231]
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) ~[na:1.8.0_231]
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) ~[na:1.8.0_231]
        at java.lang.reflect.Constructor.newInstance(Unknown Source) ~[na:1.8.0_231]
        at com.mysql.cj.util.Util.handleNewInstance(Util.java:192) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.util.Util.getInstance(Util.java:167) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.util.Util.getInstance(Util.java:174) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.exceptions.SQLError.createBatchUpdateException(SQLError.java:224) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeBatchedInserts(ClientPreparedStatement.java:755) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeBatchInternal(ClientPreparedStatement.java:426) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.StatementImpl.executeBatch(StatementImpl.java:800) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.alibaba.druid.pool.DruidPooledPreparedStatement.executeBatch(DruidPooledPreparedStatement.java:565) ~[druid-1.2.6.jar:1.2.6]
        at io.seata.server.storage.db.lock.LockStoreDataBaseDAO.doAcquireLocks(LockStoreDataBaseDAO.java:371) ~[classes!/:1.7.0]
        at io.seata.server.storage.db.lock.LockStoreDataBaseDAO.acquireLock(LockStoreDataBaseDAO.java:187) ~[classes!/:1.7.0]
        ... 24 common frames omitted
Caused by: java.sql.SQLIntegrityConstraintViolationException: Duplicate entry 'jdbc:mysql://127.0.0.1:3306/oa^^^sys_user_role^^^10000002_3' for key 'lock_table.PRIMARY'
        at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:117) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:953) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1098) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1046) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeLargeUpdate(ClientPreparedStatement.java:1371) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeBatchedInserts(ClientPreparedStatement.java:716) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        ... 29 common frames omitted
<==

根据这个堆栈，其实可以看到批量插入的时候，nextException是SQLIntegrityConstraintViolationException，如果存在其他异常，可能是数据库之类的异常，这种情况应该属于sqlexception，也不需要额外处理，直接抛出去即可

changeAtLater · 2024-09-10T01:51:58Z

Caused by: java.sql.BatchUpdateException: Duplicate entry 'jdbc:mysql://127.0.0.1:3306/oa^^^sys_user_role^^^10000002_3' for key 'lock_table.PRIMARY'
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[na:1.8.0_231]
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) ~[na:1.8.0_231]
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) ~[na:1.8.0_231]
        at java.lang.reflect.Constructor.newInstance(Unknown Source) ~[na:1.8.0_231]
        at com.mysql.cj.util.Util.handleNewInstance(Util.java:192) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.util.Util.getInstance(Util.java:167) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.util.Util.getInstance(Util.java:174) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.exceptions.SQLError.createBatchUpdateException(SQLError.java:224) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeBatchedInserts(ClientPreparedStatement.java:755) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeBatchInternal(ClientPreparedStatement.java:426) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.StatementImpl.executeBatch(StatementImpl.java:800) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.alibaba.druid.pool.DruidPooledPreparedStatement.executeBatch(DruidPooledPreparedStatement.java:565) ~[druid-1.2.6.jar:1.2.6]
        at io.seata.server.storage.db.lock.LockStoreDataBaseDAO.doAcquireLocks(LockStoreDataBaseDAO.java:371) ~[classes!/:1.7.0]
        at io.seata.server.storage.db.lock.LockStoreDataBaseDAO.acquireLock(LockStoreDataBaseDAO.java:187) ~[classes!/:1.7.0]
        ... 24 common frames omitted
Caused by: java.sql.SQLIntegrityConstraintViolationException: Duplicate entry 'jdbc:mysql://127.0.0.1:3306/oa^^^sys_user_role^^^10000002_3' for key 'lock_table.PRIMARY'
        at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:117) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:953) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1098) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1046) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeLargeUpdate(ClientPreparedStatement.java:1371) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeBatchedInserts(ClientPreparedStatement.java:716) ~[mysql-connector-java-8.0.27.jar:8.0.27]
        ... 29 common frames omitted
<==

根据这个堆栈，其实可以看到批量插入的时候，nextException是SQLIntegrityConstraintViolationException，如果存在其他异常，可能是数据库之类的异常，这种情况应该属于sqlexception，也不需要额外处理，直接抛出去即可

我用mysql测试时,SQLIntegrityConstraintViolationException在cause中, 但我写单元测试时发现, h2的SQLIntegrityConstraintViolationException在nextException中

changeAtLater · 2024-09-10T01:54:17Z

nextException并不会在日志中打印出来,因此我最后选择抛出nextException,可以更好的知道是什么异常

server/src/main/java/org/apache/seata/server/storage/db/lock/LockStoreDataBaseDAO.java

funky-eyes · 2024-09-10T13:28:19Z

Error: Failures:
Error: DataBaseLockStoreDAOTest.tes_unLocks:178 expected: but was:
Error: DataBaseLockStoreDAOTest.test_acquireLocks:100 expected: but was:
Error: DataBaseLockStoreDAOTest.test_isLockable_can:226 expected: but was:
Error: DataBaseLockStoreDAOTest.test_re_acquireLocks:138 expected: but was:
[INFO]
Error: Tests run: 184, Failures: 4, Errors: 0, Skipped: 3

codecov · 2024-09-11T01:28:25Z

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (fde59c1) to head (942091a).
Report is 1 commits behind head on 2.x.

Files with missing lines	Patch %	Lines
...a/server/storage/db/lock/LockStoreDataBaseDAO.java	33.33%	5 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #6833      +/-   ##
============================================
+ Coverage     52.41%   52.43%   +0.02%     
- Complexity     6379     6384       +5     
============================================
  Files          1080     1080              
  Lines         37565    37575      +10     
  Branches       4451     4457       +6     
============================================
+ Hits          19691    19704      +13     
+ Misses        15923    15920       -3     
  Partials       1951     1951

Files with missing lines	Coverage Δ
...a/server/storage/db/lock/LockStoreDataBaseDAO.java	`52.77% <33.33%> (+2.29%)`	⬆️

... and 3 files with indirect coverage changes

funky-eyes

LGTM

funky-eyes · 2024-09-11T01:30:33Z

Thank you for your contributions to Seata. If possible, please send your Dingtalk contact information to my email, and I will invite you to join the Seata developer group.
[email protected]

…when inserting a globallock (apache#6833)

changeAtLater added 2 commits September 9, 2024 11:43

完善批量插入锁时的异常判断逻辑

12363a8

添加单元测试

9e17d40

funky-eyes changed the title ~~完善批量插入锁时的异常判断逻辑~~ bugfix: SQLIntegrityConstraintViolationException capture incorrectly when inserting a globallock Sep 9, 2024

funky-eyes reviewed Sep 9, 2024

View reviewed changes

server/src/main/java/org/apache/seata/server/storage/db/lock/LockStoreDataBaseDAO.java Outdated Show resolved Hide resolved

server/src/main/java/org/apache/seata/server/storage/db/lock/LockStoreDataBaseDAO.java Outdated Show resolved Hide resolved

funky-eyes added this to the 2.2.0 milestone Sep 9, 2024

funky-eyes added type: bug Category issues or prs related to bug. first-time contributor first-time contributor mode: AT AT transaction mode module/server server module labels Sep 9, 2024

changeAtLater and others added 5 commits September 10, 2024 09:12

停用*号导入

68fd915

完善变更记录

4f5a53e

Merge branch '2.x' into 2.x

d2167f0

Merge branch '2.x' into 2.x

ac6345b

调整异常判断逻辑

b83dbb5

funky-eyes reviewed Sep 10, 2024

View reviewed changes

server/src/main/java/org/apache/seata/server/storage/db/lock/LockStoreDataBaseDAO.java Show resolved Hide resolved

Merge branch '2.x' into 2.x

9f27621

修复DataBaseLockStoreDAOTest单元测试异常

942091a

funky-eyes approved these changes Sep 11, 2024

View reviewed changes

funky-eyes merged commit b2f9c3a into apache:2.x Sep 11, 2024

funky-eyes mentioned this pull request Mar 20, 2025

seata 1.5.2使用mybatis-plus插入 lock_table主键重复 Duplicate entry #7235

Closed

YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025

bugfix: SQLIntegrityConstraintViolationException capture incorrectly …

17f9dfe

…when inserting a globallock (apache#6833)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bugfix: SQLIntegrityConstraintViolationException capture incorrectly when inserting a globallock #6833

bugfix: SQLIntegrityConstraintViolationException capture incorrectly when inserting a globallock #6833

Uh oh!

changeAtLater commented Sep 9, 2024

Uh oh!

funky-eyes left a comment

Uh oh!

Uh oh!

Uh oh!

funky-eyes commented Sep 10, 2024

Uh oh!

changeAtLater commented Sep 10, 2024

Uh oh!

changeAtLater commented Sep 10, 2024

Uh oh!

Uh oh!

funky-eyes commented Sep 10, 2024

Uh oh!

codecov bot commented Sep 11, 2024 •

edited

Loading

Uh oh!

funky-eyes left a comment

Uh oh!

funky-eyes commented Sep 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bugfix: SQLIntegrityConstraintViolationException capture incorrectly when inserting a globallock #6833

bugfix: SQLIntegrityConstraintViolationException capture incorrectly when inserting a globallock #6833

Uh oh!

Conversation

changeAtLater commented Sep 9, 2024

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

funky-eyes commented Sep 10, 2024

Uh oh!

changeAtLater commented Sep 10, 2024

Uh oh!

changeAtLater commented Sep 10, 2024

Uh oh!

Uh oh!

funky-eyes commented Sep 10, 2024

Uh oh!

codecov bot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

funky-eyes commented Sep 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Sep 11, 2024 •

edited

Loading