bugfix: fix post method in HttpClientUtil #6835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Sep 9, 2024
common/src/main/java/org/apache/seata/common/util/HttpClientUtil.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Sep 9, 2024
funky-eyes
reviewed
Sep 9, 2024
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
Error: /home/runner/work/incubator-seata/incubator-seata/common/src/main/java/org/apache/seata/common/util/HttpClientUtil.java:94:17: '}' is not followed by whitespace. [WhitespaceAround]
Error: /home/runner/work/incubator-seata/incubator-seata/common/src/main/java/org/apache/seata/common/util/HttpClientUtil.java:94:18: 'else' is not preceded with whitespace. [WhitespaceAround]
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6835 +/- ##
============================================
+ Coverage 52.42% 52.52% +0.09%
- Complexity 6378 6388 +10
============================================
Files 1080 1080
Lines 37560 37565 +5
Branches 4452 4453 +1
============================================
+ Hits 19690 19730 +40
+ Misses 15921 15885 -36
- Partials 1949 1950 +1
|
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
#6834
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
This problem is caused by the modification in #6536