Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bugfix: after scaling down a Raft cluster, the metadata still contains the removed node #6855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 4 commits into from
Sep 16, 2024
Merged

bugfix: after scaling down a Raft cluster, the metadata still contains the removed node #6855

funky-eyes merged 4 commits into from
Sep 16, 2024

Conversation

@funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Sep 14, 2024

…m the metadata

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6853

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 14, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels Sep 14, 2024
@codecov
Copy link

codecov bot commented Sep 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.

Project coverage is 52.30%. Comparing base (963f7f3) to head (2cf3d4d).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...he/seata/server/cluster/raft/RaftStateMachine.java 11.53% 22 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6855      +/-   ##
============================================
- Coverage     52.31%   52.30%   -0.01%     
- Complexity     6412     6414       +2     
============================================
  Files          1083     1083              
  Lines         37918    37923       +5     
  Branches       4494     4492       -2     
============================================
+ Hits          19836    19837       +1     
- Misses        16113    16114       +1     
- Partials       1969     1972       +3
Files with missing lines Coverage Δ
...in/java/org/apache/seata/common/metadata/Node.java 62.50% <ø> (ø)
...he/seata/server/cluster/raft/RaftStateMachine.java 14.73% <11.53%> (+0.12%) ⬆️

... and 3 files with indirect coverage changes

xingfudeshi
xingfudeshi approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 22f9c47 into apache:2.x Sep 16, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@funky-eyes
bugfix: after scaling down a Raft cluster, the metadata still contain…
6114e72 
…s the removed node (apache#6855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xingfudeshi xingfudeshi xingfudeshi approved these changes

@jsbxyyx jsbxyyx Awaiting requested review from jsbxyyx

@slievrly slievrly Awaiting requested review from slievrly

@lovepoem lovepoem Awaiting requested review from lovepoem

Assignees

No one assigned

Labels

module/server server module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

During Raft cluster scaling, the old nodes are not removed from the metadata

2 participants

@funky-eyes @xingfudeshi