Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bugfix: Lock contention failure in file & Raft mode did not exit #6932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 2 commits into from
Oct 18, 2024
Merged

bugfix: Lock contention failure in file & Raft mode did not exit #6932

funky-eyes merged 2 commits into from
Oct 18, 2024

Conversation

@funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Oct 18, 2024 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

when enabling local transactions, the lock contention failure in file & raft mode does not exit, leading to a lingering lock

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes
bugfix: when enabling local transactions, the lock contention failure…
a980ac8 
… in file & raft mode does not exit, leading to a lingering lock
@funky-eyes funky-eyes changed the title bugfix: when enabling local transactions, the lock contention failure in file & raft mode does not exit, leading to a lingering lock bugfix: Lock contention failure in file & Raft mode did not exit Oct 18, 2024
@funky-eyes funky-eyes added this to the 2.3.0 milestone Oct 18, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: AT AT transaction mode module/server server module labels Oct 18, 2024
@codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.56%. Comparing base (077d8a2) to head (a9b4dab).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6932   +/-   ##
=========================================
  Coverage     52.55%   52.56%           
- Complexity     6545     6548    +3     
=========================================
  Files          1122     1122           
  Lines         39860    39858    -2     
  Branches       4670     4666    -4     
=========================================
+ Hits          20950    20951    +1     
- Misses        16912    16913    +1     
+ Partials       1998     1994    -4
Files with missing lines Coverage Δ
...che/seata/server/storage/file/lock/FileLocker.java 81.39% <100.00%> (+1.84%) ⬆️

... and 5 files with indirect coverage changes

xingfudeshi
xingfudeshi approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit fabccea into apache:2.x Oct 18, 2024
@funky-eyes funky-eyes mentioned this pull request Nov 28, 2024
Closed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@funky-eyes
bugfix: Lock contention failure in file & Raft mode did not exit (apa…
ccf3047 
…che#6932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xingfudeshi xingfudeshi xingfudeshi approved these changes

@slievrly slievrly Awaiting requested review from slievrly

Assignees

No one assigned

Labels

mode: AT AT transaction mode module/server server module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@funky-eyes @xingfudeshi