Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bugfix:fix error while the "context" is key word in DM8 when delete undolog #7010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 2 commits into from
Nov 19, 2024
Merged

bugfix:fix error while the "context" is key word in DM8 when delete undolog #7010

funky-eyes merged 2 commits into from
Nov 19, 2024

Conversation

@whaon
Copy link
Contributor

@whaon whaon commented Nov 18, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix error while the "context" is key word in DM8 when delete undolog

Ⅱ. Does this pull request fix one issue?

fixes #7009

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

funky-eyes
funky-eyes reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请登记pr和作者信息至changes文件夹中的中英两版2.x.md中
Please register the PR and author information into the Chinese and English versions of the 2.x.md file located in the changes folder.

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. first-time contributor first-time contributor module/rm-datasource rm-datasource module labels Nov 18, 2024
@funky-eyes funky-eyes added this to the 2.3.0 milestone Nov 18, 2024
@codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 3.70370% with 52 lines in your changes missing coverage. Please review.

Project coverage is 52.53%. Comparing base (0a21dea) to head (cc16671).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../seata/rm/datasource/undo/dm/DmUndoLogManager.java 3.70% 52 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7010      +/-   ##
============================================
- Coverage     52.60%   52.53%   -0.07%     
+ Complexity     6582     6581       -1     
============================================
  Files          1126     1126              
  Lines         39953    40007      +54     
  Branches       4688     4694       +6     
============================================
+ Hits          21017    21019       +2     
- Misses        16932    16983      +51     
- Partials       2004     2005       +1
Files with missing lines Coverage Δ
.../seata/rm/datasource/undo/dm/DmUndoLogManager.java 6.89% <3.70%> (-5.23%) ⬇️

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@whaon
Copy link
Contributor Author

whaon commented Nov 19, 2024

请登记pr和作者信息至changes文件夹中的中英两版2.x.md中 Please register the PR and author information into the Chinese and English versions of the 2.x.md file located in the changes folder.

done

funky-eyes
funky-eyes approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

funky-eyes commented Nov 19, 2024

请把你的钉钉号发送至我的邮箱，我将邀请你加入seata社区开发者群中。
Please send your DingTalk ID to my email, and I will invite you to join the Seata community developer group
[email protected]

@funky-eyes funky-eyes added the mode: AT AT transaction mode label Nov 19, 2024
@funky-eyes funky-eyes merged commit 03595af into apache:2.x Nov 19, 2024
@funky-eyes funky-eyes mentioned this pull request Feb 27, 2025
Closed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@whaon
bugfix:fix error while the "context" is key word in DM8 when delete u…
8bdd956 
…ndolog (apache#7010)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

first-time contributor first-time contributor mode: AT AT transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

error occurs when delete undolog in 2.2.0 with DM8 DB

2 participants

@whaon @funky-eyes