Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Nov 30, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Added support for using Fury serialization UndoLog

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

set client.undo.logSerialization=fury

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.61%. Comparing base (dc08160) to head (c5f40fa).

Files with missing lines Patch % Lines
...a/rm/datasource/undo/parser/FuryUndoLogParser.java 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7037      +/-   ##
============================================
+ Coverage     52.58%   52.61%   +0.03%     
- Complexity     6681     6688       +7     
============================================
  Files          1131     1132       +1     
  Lines         40277    40290      +13     
  Branches       4723     4721       -2     
============================================
+ Hits          21179    21199      +20     
+ Misses        17072    17065       -7     
  Partials       2026     2026              
Files with missing lines Coverage Δ
...a/rm/datasource/undo/parser/FuryUndoLogParser.java 92.30% <92.30%> (ø)

... and 5 files with indirect coverage changes

# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
#	dependencies/pom.xml
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.4.0 milestone Jan 3, 2025
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/rm-datasource rm-datasource module labels Jan 3, 2025
@funky-eyes funky-eyes merged commit 8de9730 into apache:2.x Jan 3, 2025
6 checks passed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/rm-datasource rm-datasource module type: feature Category issues or prs related to feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants