bugfix: remove the condition that IPv6 must start with fe80: #7112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x will not be checked. remove starting with "fe80:"
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7112 +/- ##
============================================
- Coverage 53.19% 53.19% -0.01%
- Complexity 6799 6800 +1
============================================
Files 1133 1133
Lines 40302 40301 -1
Branches 4721 4723 +2
============================================
- Hits 21440 21439 -1
+ Misses 16820 16817 -3
- Partials 2042 2045 +3
|
funky-eyes
reviewed
Jan 15, 2025
| String ipPart = input.substring(ZERO, lastIndex); | ||
| return isIPv6StdAddress(ipPart) || isIPv6HexCompressedAddress(ipPart); | ||
| } | ||
| int lastIndex = input.lastIndexOf(PERCENT); |
Contributor
There was a problem hiding this comment.
请增加一个测试用例
Please add a test case
Contributor
Author
There was a problem hiding this comment.
新增isLinkLocalIPv6WithZoneIndex方法测试用例
added 2 commits
January 15, 2025 18:35
funky-eyes
approved these changes
Jan 15, 2025
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
LGTM
请将pr登记至2.x.md的中英两版文件中
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x will not be checked. remove starting with "fe80:"
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #7110
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews