Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@YongGoose
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7169

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.18%. Comparing base (46c9b63) to head (7241be2).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...che/seata/core/rpc/netty/NettyClientBootstrap.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7171      +/-   ##
============================================
- Coverage     52.18%   52.18%   -0.01%     
+ Complexity     6813     6812       -1     
============================================
  Files          1154     1154              
  Lines         41112    41116       +4     
  Branches       4818     4820       +2     
============================================
  Hits          21455    21455              
- Misses        17617    17618       +1     
- Partials       2040     2043       +3     
Files with missing lines Coverage Δ
...che/seata/core/rpc/netty/NettyClientBootstrap.java 57.30% <40.00%> (-2.00%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.4.0 milestone Feb 19, 2025
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/core core module labels Feb 19, 2025
@funky-eyes funky-eyes merged commit a1aba35 into apache:2.x Feb 19, 2025
8 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/core core module type: feature Category issues or prs related to feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client support for EpollEventLoopGroup

2 participants