Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Feb 28, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Add dependency-check-maven plugin to detect potential vulnerabilities.

Ⅱ. Does this pull request fix one issue?

#7140

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

You can execute the following command to run the dependency check:

mvn verify -DskipTests=true

After the command finishes, you can find the report in the target folder named dependency-check-report.html.
image

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.57%. Comparing base (efa341a) to head (26be068).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7187      +/-   ##
============================================
- Coverage     51.58%   51.57%   -0.01%     
+ Complexity     6815     6814       -1     
============================================
  Files          1169     1169              
  Lines         41505    41505              
  Branches       4857     4857              
============================================
- Hits          21409    21408       -1     
  Misses        18073    18073              
- Partials       2023     2024       +1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slievrly
Copy link
Member

slievrly commented Mar 6, 2025

@xingfudeshi
Error: Failed to execute goal org.owasp:dependency-check-maven:12.1.0:check (default) on project seata-parent: The plugin org.owasp:dependency-check-maven:12.1.0 requires Maven version 3.6.3

@xingfudeshi
Copy link
Member Author

@xingfudeshi Error: Failed to execute goal org.owasp:dependency-check-maven:12.1.0:check (default) on project seata-parent: The plugin org.owasp:dependency-check-maven:12.1.0 requires Maven version 3.6.3

Fixed.

@slievrly slievrly changed the title optimize:Add dependency-check-maven plugin to detect potential vulnerabilities optimize: add dependency-check-maven plugin to detect potential vulnerabilities Mar 8, 2025
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 62aa6af into apache:2.x Mar 8, 2025
8 checks passed
@slievrly slievrly added this to the 2.4.0 milestone Mar 8, 2025
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants