Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@YoWuwuuuw
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

#7208

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.79%. Comparing base (d300796) to head (128167d).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7227      +/-   ##
============================================
+ Coverage     53.61%   53.79%   +0.17%     
- Complexity     7128     7149      +21     
============================================
  Files          1171     1171              
  Lines         41619    41619              
  Branches       4877     4877              
============================================
+ Hits          22315    22388      +73     
+ Misses        17194    17118      -76     
- Partials       2110     2113       +3     
Files with missing lines Coverage Δ
...ery/registry/consul/ConsulRegistryServiceImpl.java 60.33% <ø> (+58.67%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slievrly slievrly changed the title add mock test for seata-discovery-consul module test: add mock test for seata-discovery-consul module Mar 17, 2025
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 2.4.0 milestone Mar 17, 2025
@slievrly slievrly merged commit 3e4bc61 into apache:2.x Mar 17, 2025
8 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants