optimize: seata-server log configuration #7259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7259 +/- ##
============================================
- Coverage 54.24% 54.22% -0.02%
Complexity 7266 7266
============================================
Files 1178 1178
Lines 41952 41958 +6
Branches 4923 4925 +2
============================================
- Hits 22758 22753 -5
- Misses 17040 17053 +13
+ Partials 2154 2152 -2 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
slievrly
reviewed
Mar 31, 2025
Member
slievrly
left a comment
There was a problem hiding this comment.
It looks like these configuration files need to be modified as well.
https://github.com/apache/incubator-seata/blob/2.x/server/src/main/resources/application.example.yml
https://github.com/apache/incubator-seata/blob/2.x/server/src/main/resources/application.raft.example.yml
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Optimisation Points:
If you need to collect seata-server logs to Kafka and logstash, you need to modify the logback-spring.xml configuration file (uncomment the corresponding appender), and you need to revise the specific configuration of Kafka-appender by revising kafka-appender.xml and application.yml.
It's a hassle.
Optimisation Scheme: Establish SpringProperty mapping
The configuration of open Kafka, logstash and metric's appender will be transferred to application.yml.
Transfer the specific configuration of Kafka to application.yml.
About dynamic updates to configuration changes
in logback-spring.xml,
configuration scan="true" scanPeriod="60 seconds" debug="false"The configuration is scaned every minute, so if you introduce a configuration center to change the yml configuration, it is visible to logback originally.
Ⅱ. Does this pull request fix one issue?
#4648
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews