test: add UT for rm datasource module #7275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7275 +/- ##
============================================
+ Coverage 54.26% 54.33% +0.06%
- Complexity 7267 7280 +13
============================================
Files 1178 1178
Lines 41962 41962
Branches 4923 4923
============================================
+ Hits 22772 22799 +27
+ Misses 17038 17007 -31
- Partials 2152 2156 +4 see 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @slievrly, I've added the license header as requested. Please take another look when convenient. Thanks! |
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses #1714 to improve test coverage for the
seata-rm-datasourcemodule, particularly theorg.apache.seata.rmpackage, which had low method and line coverage.Before:
org.apache.seata.rm: 42% line coverageBaseDataSourceResource: Not explicitly testedAfter:
org.apache.seata.rm: 73% line coverageBaseDataSourceResourceWhat
BaseDataSourceResourceusing:DummyHoldableto simulate holdable resource state.DummyResourceto override abstract methods (e.g.,getConnection).hold(),release(),lookup()Mockitoand followed Seata’s test structure and style.How to Verify
Run:
./mvnw clean test jacoco:report -pl rmThen open the coverage report at:
Note: I have read the contributing guidelines and followed the testing structure and code style.