bugfix: fix codecov bug #7356
bugfix: fix codecov bug #7356
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7356 +/- ##
============================================
- Coverage 54.94% 54.94% -0.01%
Complexity 7415 7415
============================================
Files 1181 1181
Lines 42136 42136
Branches 4945 4945
============================================
- Hits 23152 23151 -1
- Misses 16803 16808 +5
+ Partials 2181 2177 -4 see 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
The |
funky-eyes
left a comment
There was a problem hiding this comment.
Please register this PR in the 2.x.md
I just got home! 🥹 |
|
PTAL ⚡️ |
|
I think we can merge this PR once we confirm that |
codecov.yml
Outdated
| if_not_found: success | ||
| target: 2.x | ||
| changes: yes #only care the changed files | ||
| changes: true |
There was a problem hiding this comment.
It looks like this setting was added to limit the comparison to only the modified files, but in reality, it behaves differently.
It actually detects changes in code coverage even for lines that weren’t directly modified in the PR or commit.
So I think we need to decide whether to keep it or remove it. What are your thoughts?
There was a problem hiding this comment.
Since this prompt keeps appearing, I decided to delete the codecov/changes stage. I think we should revert it back to "no". I don't believe we need this stage as it doesn't seem to provide any positive value.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews