test: add UT for org.apache.seata.spring.annotation.scannercheckers #7423
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the scanner checkers in the seata spring module to ensure that bean scope and package scanning validations behave as expected.
- Adds tests for ScopeBeansScannerChecker covering scenarios with null bean factory, non-annotated bean definitions, and various scope exclusions.
- Adds tests for PackageScannerChecker to verify package matching behaviors and case sensitivity.
- Adds tests for ConfigBeansScannerChecker to validate bean name patterns for configuration classes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spring/src/test/java/org/apache/seata/spring/annotation/scannercheckers/ScopeBeansScannerCheckerTest.java | Unit tests to verify scope exclusion logic and helper methods using reflection |
| spring/src/test/java/org/apache/seata/spring/annotation/scannercheckers/PackageScannerCheckerTest.java | Unit tests covering package scanning and case sensitivity checks |
| spring/src/test/java/org/apache/seata/spring/annotation/scannercheckers/ConfigBeansScannerCheckerTest.java | Parameterized tests and specific cases for validating configuration bean naming |
| * Helper method to get the EXCLUDE_SCOPE_SET field value | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| private Set<String> getExcludeScopeSet() throws Exception { |
There was a problem hiding this comment.
Consider refactoring the reflection-based helper methods into a common test utility to reduce code duplication and improve maintainability.
| * Helper method to get the SCANNABLE_PACKAGE_SET field value | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| private Set<String> getScannablePackageSet() throws Exception { |
There was a problem hiding this comment.
Consider extracting the reflection-based helper methods for field access into a shared utility class for improved maintainability and to reduce duplication across test files.
There was a problem hiding this comment.
Yes, but not necessary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7423 +/- ##
============================================
+ Coverage 59.10% 59.24% +0.13%
Complexity 531 531
============================================
Files 1281 1281
Lines 46142 46142
Branches 5561 5561
============================================
+ Hits 27271 27335 +64
+ Misses 16302 16232 -70
- Partials 2569 2575 +6 see 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #7377
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews