-
Notifications
You must be signed in to change notification settings - Fork 8.9k
optimize: add contribution intention check box to issue template #7466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7466 +/- ##
============================================
+ Coverage 60.31% 60.34% +0.02%
Complexity 658 658
============================================
Files 1281 1281
Lines 48308 48308
Branches 5676 5676
============================================
+ Hits 29138 29152 +14
+ Misses 16562 16548 -14
Partials 2608 2608 🚀 New features to boost your workflow:
|
changes/en-us/2.x.md
Outdated
| ### feature: | ||
|
|
||
| - [[#7261](https://github.com/apache/incubator-seata/pull/7261)] enforce account initialization and disable default credentials | ||
| - [[#7466](https://github.com/apache/incubator-seata/pull/7466)] add contribution intention check box to issue template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this functionality belongs to the optimization category, rather than being a feature.
slievrly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Most issue creators do not have write permissions to assign issues. So, add a confirmation checkbox to the issue template, allowing them to express their willingness to contribute. This helps developers identify which issues are available to be taken.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Go:
YoWuwuuuw#26
YoWuwuuuw#25
Ⅴ. Special notes for reviews