optimize: remove client id metric #7484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7484 +/- ##
============================================
+ Coverage 60.61% 60.81% +0.19%
Complexity 658 658
============================================
Files 1308 1308
Lines 49446 49434 -12
Branches 5811 5811
============================================
+ Hits 29971 30062 +91
+ Misses 16814 16710 -104
- Partials 2661 2662 +1
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
funky-eyes
reviewed
Jun 30, 2025
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
codecov/patch — 0.00% of diff hit (target 60.31%)
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
Contributor
Author
all ci test is passed |
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: remove client id metric
Ⅱ. Does this pull request fix one issue?
There is oom risk, clientid with the client reconnect, or destroy the reconstruction is not the same, this belongs to the unenumerable values, Prometheus indicators can not have unenumerable values, each value will be cached as a line of Prometheus collection of indicators, over time the memory will be used by these no longer use the clientid of the indicators will be burst.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews