bugfix: ensure visibility of rm and The methods in MockTest are executed in order #7662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7662 +/- ##
============================================
+ Coverage 61.03% 61.19% +0.16%
Complexity 666 666
============================================
Files 1314 1314
Lines 49760 49760
Branches 5849 5849
============================================
+ Hits 30370 30451 +81
+ Misses 16687 16579 -108
- Partials 2703 2730 +27 see 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
funky-eyes
reviewed
Sep 26, 2025
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
#7585
With the help of @funky-eyes's analysis, I think it is not a network or port problem, but a visibility problem.
Because the rm member variable in RmClientTest is not declared as volatile, this may cause the rm variable to be modified multiple times during concurrent testing, thus causing this problem。
Here is the fix I made for the problem:
Ⅱ. Does this pull request fix one issue?
fixes #7558
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
mvn clean test
Ⅴ. Special notes for reviews