Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@YvCeung
Copy link
Contributor

@YvCeung YvCeung commented Oct 29, 2025

Ⅰ. Describe what this PR did

修复了 Http2HttpHandler 在解析 application/x-www-form-urlencoded 请求时可能导致解析失败的问题。
Fixed an issue in Http2HttpHandler where parsing requests with the application/x-www-form-urlencoded content type could fail.

Ⅱ. Does this pull request fix one issue?

fix #7732

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

the integration test cases can validate it
org.apache.seata.server.controller.ClusterControllerTest#watchTimeoutTest_withHttp2

Ⅴ. Special notes for reviews

@YvCeung YvCeung changed the title fix: error parsing application/x-www-form-urlencoded requests in Http2HttpHandler bugfix: fix error parsing application/x-www-form-urlencoded requests in Http2HttpHandler Oct 29, 2025
@funky-eyes funky-eyes added this to the 2.6.0 milestone Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.03%. Comparing base (8682358) to head (416abb7).
⚠️ Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...he/seata/core/rpc/netty/http/Http2HttpHandler.java 70.58% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7749      +/-   ##
============================================
+ Coverage     66.00%   66.03%   +0.02%     
- Complexity      992      994       +2     
============================================
  Files          1323     1323              
  Lines         50137    50152      +15     
  Branches       5922     5928       +6     
============================================
+ Hits          33095    33117      +22     
+ Misses        14137    14133       -4     
+ Partials       2905     2902       -3     
Files with missing lines Coverage Δ
...he/seata/core/protocol/detector/Http2Detector.java 82.14% <ø> (+35.71%) ⬆️
...rpc/netty/http/filter/HttpRequestParamWrapper.java 86.36% <100.00%> (+0.12%) ⬆️
...he/seata/core/rpc/netty/http/Http2HttpHandler.java 74.16% <70.58%> (-0.37%) ⬇️

... and 12 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@YvCeung YvCeung added module/core core module type: bug Category issues or prs related to bug. labels Oct 30, 2025
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 94a44ef into apache:2.x Oct 31, 2025
11 checks passed
YvCeung added a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/core core module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Http2HttpHandler fails to parse application/x-www-form-urlencoded request body

2 participants