-
Notifications
You must be signed in to change notification settings - Fork 8.9k
bugfix: fix error parsing application/x-www-form-urlencoded requests in Http2HttpHandler #7749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d content type could fail
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7749 +/- ##
============================================
+ Coverage 66.00% 66.03% +0.02%
- Complexity 992 994 +2
============================================
Files 1323 1323
Lines 50137 50152 +15
Branches 5922 5928 +6
============================================
+ Hits 33095 33117 +22
+ Misses 14137 14133 -4
+ Partials 2905 2902 -3
🚀 New features to boost your workflow:
|
funky-eyes
approved these changes
Oct 31, 2025
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YvCeung
added a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
…in Http2HttpHandler (apache#7749)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
修复了 Http2HttpHandler 在解析 application/x-www-form-urlencoded 请求时可能导致解析失败的问题。
Fixed an issue in Http2HttpHandler where parsing requests with the application/x-www-form-urlencoded content type could fail.
Ⅱ. Does this pull request fix one issue?
fix #7732
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
the integration test cases can validate it
org.apache.seata.server.controller.ClusterControllerTest#watchTimeoutTest_withHttp2Ⅴ. Special notes for reviews