Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dsomehan
Copy link
Contributor

@dsomehan dsomehan commented Nov 6, 2025

Ⅰ. Describe what this PR did

The jdbc implementation of shentongdata requires the same XaConnection object for the same transaction

  1. In the DataSourceProxyXA constructor, · set shouldbeheld to true if dbtype is the shentongdata(oscar) database
  2. Adding unit tests

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@dsomehan dsomehan changed the title bugfix: shentongdata xa mode should be hold the same connection bugfix:shentongdata xa mode should be hold the same connection Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.19%. Comparing base (1f69f34) to head (ebcf287).
⚠️ Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7771      +/-   ##
============================================
- Coverage     69.23%   69.19%   -0.04%     
- Complexity      992      994       +2     
============================================
  Files          1322     1322              
  Lines         50173    50175       +2     
  Branches       5931     5932       +1     
============================================
- Hits          34736    34721      -15     
- Misses        12523    12541      +18     
+ Partials       2914     2913       -1     
Files with missing lines Coverage Δ
...ache/seata/rm/datasource/xa/DataSourceProxyXA.java 70.49% <100.00%> (+1.00%) ⬆️

... and 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maple525866
Copy link
Contributor

Please add change log @dsomehan

…d-same-connect' into bugfix:shentong-xa-should-be-hold-same-connect

# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
@dsomehan dsomehan requested a review from maple525866 November 10, 2025 08:21
Copy link
Contributor

@maple525866 maple525866 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix:shentongdata xa mode should be hold the same connection bugfix: shentongdata xa mode should be hold the same connection Nov 12, 2025
@maple525866 maple525866 merged commit 5a89e80 into apache:2.x Nov 12, 2025
11 checks passed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants