-
Notifications
You must be signed in to change notification settings - Fork 8.9k
feature: Automatically calculate the values for JVM parameters #7872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7872 +/- ##
============================================
+ Coverage 71.03% 71.07% +0.04%
Complexity 797 797
============================================
Files 1294 1294
Lines 49528 49528
Branches 5873 5873
============================================
+ Hits 35182 35204 +22
+ Misses 11437 11413 -24
- Partials 2909 2911 +2 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xingfudeshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maple525866
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
根据当前内存值自动计算 JVM 参数(如 Xmx 和 Xms)
Automatically calculate the values for JVM parameters such as Xmx and Xms based on the current memory value
对于windows只支持环境变量的内存分配,对于容器环境和虚拟机来说,4G的机器将采用70%,4G以上的则采用75%的内存
For Windows, only memory allocation through environment variables is supported. For container environments and virtual machines, 70% of memory will be used for machines with 4GB of memory, and 75% for those with more than 4GB
Ⅱ. Does this pull request fix one issue?
fixes #7836
Ⅲ. Why don't you add test cases (unit test/integration test)?
对于windows的改动:支持通过环境变量来设置内存,当然也保留了原先的默认值
For changes to Windows: It now supports setting memory through environment variables, while also retaining the original default values
对于容器环境 For container environments:
对于虚拟机 For virtual machines:
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews