-
Notifications
You must be signed in to change notification settings - Fork 8.9k
bugfix: consoleApiService that could not be found #7959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bean loading issue where ConsoleApiService could not be found after packaging, due to bean loading order/priority changes when not using a fat JAR approach. The fix addresses cross-module conditional dependencies by using more appropriate conditional bean annotations.
Changes:
- Modified
ConsoleLocalServiceImplto conditionally load based onNamingServerLocalMarkerImpl(same module) instead ofConsoleRemoteServiceImpl(different module) - Modified
ConsoleRemoteServiceImplto conditionally load based on bean name "consoleLocalServiceImpl" instead ofNamingServerLocalMarkerinterface - Added logging statements to track bean initialization
- Updated changelog entries for version 2.6.0
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| namingserver/src/main/java/org/apache/seata/namingserver/service/ConsoleLocalServiceImpl.java | Changed conditional bean loading from cross-module class dependency to same-package class, removed unused import, added initialization logging |
| console/src/main/java/org/apache/seata/mcp/service/impl/ConsoleRemoteServiceImpl.java | Changed conditional bean loading to use bean name instead of interface, removed unused import, added initialization logging |
| changes/zh-cn/2.6.0.md | Added Chinese changelog entry for the fix |
| changes/en-us/2.6.0.md | Added English changelog entry for the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
console/src/main/java/org/apache/seata/mcp/service/impl/ConsoleRemoteServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #7958
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews