test: initialize cluster term and correct HTTP/2 timeout for watch tests #7969
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7969 +/- ##
============================================
+ Coverage 71.72% 71.81% +0.09%
Complexity 872 872
============================================
Files 1300 1300
Lines 49727 49727
Branches 5908 5908
============================================
+ Hits 35667 35713 +46
+ Misses 11122 11083 -39
+ Partials 2938 2931 -7 see 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This change adds initial cluster state setup by publishing a
ClusterChangeEventwith term=1 at the start of bothwatch()andwatch_withHttp2()tests. It also corrects the HTTP/2 timeout inwatch_withHttp2()from 30ms to 30000ms. Before the change, the tests passed in some cases and failed on the others. They passed in sequential builds becausewatch()would set the server's static state to term=2, causingwatch_withHttp2()to receive an immediate response when it requested term=1, making the 30ms timeout look sufficient. In parallel builds or isolated execution, the tests failed (sometimes) because without the cached state, the server would wait for the 2-second delayed event, exceeding the 30ms timeout. By resetting the state to term=1 before each test, both tests now start with an initial baseline and properly validate the long-polling behavior without giving false positives.Ⅱ. Does this pull request fix one issue?
fixes #7963
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
I’m new here, please let me know if anything in this PR should be done differently