Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[KYUUBI #7163][SPARK] Check whether engine context stopped in engine terminating checker #7167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
turboFei wants to merge 4 commits into from
Closed

[KYUUBI #7163][SPARK] Check whether engine context stopped in engine terminating checker #7167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca551c2
check engine context stopped
turboFei Aug 7, 2025
cf9e40e
no hard code
turboFei Aug 7, 2025
cd542de
Revert "no hard code"
turboFei Aug 7, 2025
835cb3d
SparkContext
turboFei Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSQLSessionManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,4 +227,8 @@ class SparkSQLSessionManager private (name: String, spark: SparkSession)
opHandle: OperationHandle): Path = {
new Path(getSessionResultSavePath(sessionHandle), opHandle.identifier.toString)
}

override private[kyuubi] def isEngineContextStopped = {
spark.sparkContext.isStopped
}
}
15 changes: 11 additions & 4 deletions kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,10 +345,15 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
if (idleTimeout > 0) {
val checkTask = new Runnable {
override def run(): Unit = {
if (!shutdown && System.currentTimeMillis() - latestLogoutTime > idleTimeout &&
getActiveUserSessionCount <= 0) {
info(s"Idled for more than $idleTimeout ms, terminating")
stop()
if (!shutdown) {
if (System.currentTimeMillis() - latestLogoutTime > idleTimeout &&
getActiveUserSessionCount <= 0) {
info(s"Idled for more than $idleTimeout ms, terminating")
stop()
} else if (isEngineContextStopped) {
error(s"Engine's SparkContext is stopped, terminating")
stop()
}
}
}
}
Expand All @@ -360,4 +365,6 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
TimeUnit.MILLISECONDS)
}
}

private[kyuubi] def isEngineContextStopped: Boolean = false
}
Loading