[KYUUBI-7316] Fix parsePropertyFromUrl to remove query string from parsed values #7317
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7317 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 698 698
Lines 43654 43658 +4
Branches 5896 5897 +1
======================================
- Misses 43654 43658 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fixed the
parsePropertyFromUrlmethod inUtils.javato properly remove query string parts (everything after ?) from parsed JDBC URL property values, making it consistent with theextractURLComponentsmethod.When parsing JDBC URLs with query strings like:
jdbc:hive2://host:10012/db;auth=JWT?kyuubi.session.cluster=clusterA.The
parsePropertyFromUrlmethod was incorrectly returningJWT?kyuubi.session.cluster=clusterAfor theauthproperty, whileextractURLComponentscorrectly returned onlyJWT. This inconsistency could cause authentication failures in JWT auth scenarios with additional query parameters.How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.