Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix off-by-one in StackTraceStringResolver #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2024
Merged

Fix off-by-one in StackTraceStringResolver #3212

merged 3 commits into from
Nov 18, 2024

Conversation

vy
Copy link
Member

@vy vy commented Nov 18, 2024

Fixes #3194.

@vy vy added bug Incorrect, unexpected, or unintended behavior of existing code layouts Affects one or more Layout plugins labels Nov 18, 2024
@vy vy added this to the 2.25.0 milestone Nov 18, 2024
@vy vy requested a review from ppkarwasz November 18, 2024 08:33
@vy vy self-assigned this Nov 18, 2024
@vy vy mentioned this pull request Nov 18, 2024
Closed
ppkarwasz
ppkarwasz approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The change seems simple enough to include it in 2.24.2.
If you wish to include it, can you change the target of this PR to 2.24.x?

@vy vy changed the base branch from 2.x to 2.24.x November 18, 2024 19:15
@vy vy changed the base branch from 2.24.x to 2.x November 18, 2024 19:15
@vy vy mentioned this pull request Nov 18, 2024
Merged
@vy vy merged commit caffa21 into 2.x Nov 18, 2024
9 checks passed
@vy vy deleted the fix/2.x/JTL-StackTraceStringResolver-3194 branch November 18, 2024 19:28
@vy
Copy link
Member Author

vy commented Nov 18, 2024

The change seems simple enough to include it in 2.24.2. If you wish to include it, can you change the target of this PR to 2.24.x?

Changing the target to 2.24.x in the GitHub interface dragged in ~150 commits. I merged this one, and created #3216 for 2.24.x instead.

ppkarwasz pushed a commit that referenced this pull request Nov 18, 2024
@vy
Fix off-by-one in StackTraceStringResolver (#3216)
efba2fb 
Fixes #3194, ports #3212.
ppkarwasz pushed a commit that referenced this pull request Nov 21, 2024
@vy @ppkarwasz
Fix off-by-one in StackTraceStringResolver (#3216)
34ccf4c 
Fixes #3194, ports #3212.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz approved these changes

Assignees

@vy vy

Labels
bug Incorrect, unexpected, or unintended behavior of existing code layouts Affects one or more Layout plugins
Projects
None yet
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.

ArrayIndexOutOfBoundsException is thrown when using JsonTemplateLayout and pointMatcherStrings to truncate stack trace
2 participants
@vy @ppkarwasz