-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Set Guice class loading to CHILD - avoid using terminally deprecated methods #10992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+112
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
approved these changes
Jul 24, 2025
…methods Default Guice class loading uses a terminally deprecated JDK memory-access classes. Fix apache#10312
1f7742a to
641f9fd
Compare
|
This has been added to the 4.1.0 milestone, but will this also be included in the 3.x series? |
Member
|
rpx99
pushed a commit
to rpx99/eclipse.jdt.ls
that referenced
this pull request
Nov 12, 2025
Add -Dguice_custom_class_loading=CHILD to avoid sun.misc.Unsafe warnings on Java 21+. This prevents "terminally deprecated method" warnings from Guice 5.1.0's HiddenClassDefiner. Changes: - Add flag to all Eclipse launch configurations - Add flag to tycho-surefire test configuration - Update README with Java 21+ compatibility section - Document flag in command-line example Based on Maven fix: apache/maven#10992 Resolves sun.misc.Unsafe::staticFieldBase deprecation warnings
rpx99
pushed a commit
to rpx99/eclipse.jdt.ls
that referenced
this pull request
Nov 14, 2025
Add -Dguice_custom_class_loading=CHILD to avoid sun.misc.Unsafe warnings on Java 21+. This prevents "terminally deprecated method" warnings from Guice 5.1.0's HiddenClassDefiner. Changes: - Add flag to all Eclipse launch configurations - Add flag to tycho-surefire test configuration - Update README with Java 21+ compatibility section - Document flag in command-line example Based on Maven fix: apache/maven#10992 Resolves sun.misc.Unsafe::staticFieldBase deprecation warnings
rpx99
pushed a commit
to rpx99/eclipse.jdt.ls
that referenced
this pull request
Nov 14, 2025
Add -Dguice_custom_class_loading=CHILD to avoid sun.misc.Unsafe warnings on Java 21+. This prevents "terminally deprecated method" warnings from Guice 5.1.0's HiddenClassDefiner. Changes: - Add flag to Eclipse launch configurations (3 files) - Add flag to product definitions (languageServer, syntaxServer) - Add flag to tycho-surefire test configuration Based on Maven fix: apache/maven#10992 Resolves sun.misc.Unsafe::staticFieldBase deprecation warnings
rpx99
added a commit
to rpx99/eclipse.jdt.ls
that referenced
this pull request
Nov 14, 2025
Add -Dguice_custom_class_loading=CHILD to avoid sun.misc.Unsafe warnings on Java 21+. This prevents "terminally deprecated method" warnings from Guice 5.1.0's HiddenClassDefiner. Changes: - Add flag to Eclipse launch configurations (3 files) - Add flag to product definitions (languageServer, syntaxServer) - Add flag to tycho-surefire test configuration Based on Maven fix: apache/maven#10992 Resolves sun.misc.Unsafe::staticFieldBase deprecation warnings
rpx99
added a commit
to rpx99/eclipse.jdt.ls
that referenced
this pull request
Nov 14, 2025
Add -Dguice_custom_class_loading=CHILD to avoid sun.misc.Unsafe warnings on Java 21+. This prevents "terminally deprecated method" warnings from Guice 5.1.0's HiddenClassDefiner. Changes: - Add flag to Eclipse launch configurations (3 files) - Add flag to product definitions (languageServer, syntaxServer) - Add flag to tycho-surefire test configuration Based on Maven fix: apache/maven#10992 Resolves sun.misc.Unsafe::staticFieldBase deprecation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default Guice class loading uses a terminally deprecated JDK memory-access classes.
Fix #10312