Bump actions/setup-java from 5.4.0 to 5.5.0#12459
Closed
gnodet wants to merge 1 commit into
Closed
Conversation
setup-java v5.5.0 now sets MAVEN_ARGS=-ntp by default, which suppresses transfer progress output. This breaks 3 integration tests that verify transfer listener behavior (mng-4461, mng-4829, mng-6240). Add show-download-progress: true to the integration-test job so the ITs can still exercise Maven's transfer progress output. Co-Authored-By: Claude Opus 4.6 <[email protected]>
gnodet
commented
Jul 10, 2026
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
Review — CI Version Bump
Clean version bump of actions/setup-java from v5.4.0 to v5.5.0 on the maven-3.9.x branch. Both pinned commit hashes in the workflow are correctly updated.
The addition of show-download-progress: true on the integration-test job is a sensible change — v5.5.0 may change the default download progress output behavior, and this ensures ITs that verify transfer progress continue to work. All 18 CI checks pass. ✅
No issues found. LGTM (own PR, can't APPROVE).
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 10, 2026
Reviewed apache#12459 and apache#12460 (actions/setup-java version bumps). Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Author
|
Closing in favor of pushing the fix directly to the Dependabot branch on #12438. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-javafrom 5.4.0 to 5.5.0show-download-progress: trueto the integration-test job to fix CI failuresContext
Supersedes #12438.
setup-javav5.5.0 (changelog) introduces a new default that setsMAVEN_ARGS=-ntp(--no-transfer-progress) to suppress Maven transfer/download progress output in CI logs (actions/setup-java#1053).Since
MAVEN_ARGSis honored by Maven 3.9.0+, this suppresses transfer progress output in the forked Maven processes spawned by the integration tests, breaking 3 ITs that verify transfer listener behavior:MavenITmng4829ChecksumFailureWarningTestMavenITmng4461ArtifactUploadMonitorTestMavenITmng6240PluginExtensionAetherProviderThe fix adds
show-download-progress: trueto thesetup-javastep in the integration-test job, which opts out of the new-ntpdefault. The build job keeps the default (cleaner logs).Test plan
🤖 Generated with Claude Code