Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MNG-8396] Backport: add cache layer to the filtered dep graph #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

[MNG-8396] Backport: add cache layer to the filtered dep graph #2393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b37f4e
[MNG-8396] Backport: add cache layer to the filtered dep graph
cstamas May 26, 2025
2a12d7e
Needs more; key needs to be proper key
cstamas May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions maven-core/src/main/java/org/apache/maven/graph/FilteredProjectDependencyGraph.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.concurrent.ConcurrentHashMap;
import java.util.stream.Collectors;

import org.apache.maven.execution.ProjectDependencyGraph;
Expand All @@ -42,6 +43,34 @@ class FilteredProjectDependencyGraph implements ProjectDependencyGraph {

private final List<MavenProject> sortedProjects;

private final Map<Key, List<MavenProject>> cache = new ConcurrentHashMap<>();

private static class Key {
private final MavenProject project;
private final boolean transitive;
private final boolean upstream;

private Key(MavenProject project, boolean transitive, boolean upstream) {
this.project = project;
this.transitive = transitive;
this.upstream = upstream;
}

@Override
public boolean equals(Object o) {
if (o == null || getClass() != o.getClass()) {
return false;
}
Key key = (Key) o;
return Objects.equals(project, key.project) && transitive == key.transitive && upstream == key.upstream;
}

@Override
public int hashCode() {
return Objects.hash(project, transitive, upstream);
}
}

/**
* Creates a new project dependency graph from the specified graph.
*
Expand Down Expand Up @@ -76,12 +105,28 @@ public List<MavenProject> getSortedProjects() {

@Override
public List<MavenProject> getDownstreamProjects(MavenProject project, boolean transitive) {
return applyFilter(projectDependencyGraph.getDownstreamProjects(project, transitive), transitive, false);
Key key = new Key(project, transitive, false);
// Do not use computeIfAbsent here, as the computation is recursive
// and this is not supported by computeIfAbsent.
List<MavenProject> list = cache.get(key);
if (list == null) {
list = applyFilter(projectDependencyGraph.getDownstreamProjects(project, transitive), transitive, false);
cache.put(key, list);
}
return list;
}

@Override
public List<MavenProject> getUpstreamProjects(MavenProject project, boolean transitive) {
return applyFilter(projectDependencyGraph.getUpstreamProjects(project, transitive), transitive, true);
Key key = new Key(project, transitive, true);
// Do not use computeIfAbsent here, as the computation is recursive
// and this is not supported by computeIfAbsent.
List<MavenProject> list = cache.get(key);
if (list == null) {
list = applyFilter(projectDependencyGraph.getUpstreamProjects(project, transitive), transitive, true);
cache.put(key, list);
}
return list;
}

/**
Expand Down