Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRELEASE-851]: javaHome argument is now honored in InvokerMavenExecutor #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[MRELEASE-851]: javaHome argument is now honored in InvokerMavenExecutor #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...lease-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ public void executeGoals(

cl.addEnvironment("MAVEN_TERMINATE_CMD", "on");

if (releaseEnvironment.getJavaHome() != null) {
cl.addEnvironment("JAVA_HOME", releaseEnvironment.getJavaHome().getAbsolutePath());
}

if (settingsFile != null) {
cl.createArg().setValue("-s");
cl.createArg().setFile(settingsFile);
Expand Down
1 change: 1 addition & 0 deletions ...ease-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public void executeGoals(
// fix for MRELEASE-1105
// .addShellEnvironment( "MAVEN_DEBUG_OPTS", "" )
.setBatchMode(true)
.setJavaHome(releaseEnvironment.getJavaHome())
.setOutputHandler(getLogger()::info)
.setErrorHandler(getLogger()::error);

Expand Down
2 changes: 1 addition & 1 deletion maven-release-plugin/src/main/java/org/apache/maven/plugins/release/AbstractReleaseMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public abstract class AbstractReleaseMojo extends AbstractMojo {
private File mavenHome;

/**
* The {@code JAVA_HOME} parameter to use for forked Maven invocations.
* The Java home parameter to use for forked Maven invocations.
*
* @since 2.0-beta-8
*/
Expand Down