Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

michael-o
Copy link
Member

@cstamas Please have a sharp look before I continue upgrading. I am not 100% certain that my fix is correct.

@michael-o
Copy link
Member Author

Amy opinion on the modified code? Otherwise I will update piece by piece and merge next couple of days.

Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, go ahead

@michael-o
Copy link
Member Author

LGTM, go ahead

Does the getter change makes sense?

@cstamas
Copy link
Member

cstamas commented Jun 13, 2024

For me does, as I explained you when showed the gist: https://gist.github.com/cstamas/b847b879a0ca072c8cdc2aac4f2ce797

You are not interested in full transitive hull, you release this current project (but you need to get resolved versions if ranges are used).

@michael-o michael-o marked this pull request as ready for review June 13, 2024 19:31
@michael-o michael-o changed the title Mrelease 1145 [MRELEASE-1145] Upgrade to Maven 3.6.3 Jun 13, 2024
@asfgit asfgit merged commit fa6c3db into master Jun 13, 2024
@michael-o michael-o deleted the MRELEASE-1145 branch June 13, 2024 20:03
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Jun 16, 2024
@jira-importer
Copy link

Resolve #1321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants