Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jul 13, 2024

This removes multiple screens of log cruft from every build that uses the shade plugin.

@elharo elharo requested a review from michael-o July 13, 2024 11:51
@elharo
Copy link
Contributor Author

elharo commented Jul 13, 2024

Flakes:

[INFO] ------------------------------------------------------------------------
Error: Failed to execute goal on project shadeMT4: Could not resolve dependencies for project org.apache.maven.its.shade.parallel:shadeMT4:jar:1.0.0-SNAPSHOT: Could not transfer artifact org.springframework:spring-aop:jar:5.3.31 from/to mrm-maven-plugin (http://localhost:50540): D:\a\maven-shade-plugin\maven-shade-plugin\target\local-repo\org\springframework\spring-aop\5.3.31\spring-aop-5.3.31.jar.part.lock (Access is denied) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project shadeMT4: Could not resolve dependencies for project org.apache.maven.its.shade.parallel:shadeMT4:jar:1.0.0-SNAPSHOT: Could not transfer artifact org.springframework:spring-aop:jar:5.3.31 from/to mrm-maven-plugin (http://localhost:50540): D:\a\maven-shade-plugin\maven-shade-plugin\target\local-repo\org\springframework\spring-aop\5.3.31\spring-aop-5.3.31.jar.part.lock (Access is denied)
at org.apache.maven.lifecyc

@elharo elharo merged commit 906a7ce into master Jul 13, 2024
@elharo elharo deleted the debug branch July 13, 2024 12:44
@jira-importer
Copy link

Resolve #676

1 similar comment
@jira-importer
Copy link

Resolve #676

@pan3793
Copy link
Member

pan3793 commented Aug 16, 2025

I'd like to request to revert this change. The list is very important to let the user know which deps are shipped into the final shaded jar, especially when deps pull lots of transitive deps. If someone thinks it's noisy, please consider making the log level configurable.

@elharo
Copy link
Contributor Author

elharo commented Aug 16, 2025

They are configurable. If you want to see this set the log level to debug.

@pan3793
Copy link
Member

pan3793 commented Aug 17, 2025

what I mean "configurable" is, allow setting those message level via plugin's configuration, not run mvn command in debug mode.

@martinpaljak
Copy link

I'd like to request to revert this change. The list is very important to let the user know which deps are shipped into the final shaded jar, especially when deps pull lots of transitive deps. If someone thinks it's noisy, please consider making the log level configurable.

Same here. Made a feature request to bring it back under a verbose config option. #756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants