This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-514] Add clip_global_norm(row_sparse_grad). Fix row_sparse_param.save(). Fix trainer init_kvstore#11266
Merged
Merged
Conversation
szha
approved these changes
Jun 17, 2018
Contributor
|
@eric-haibin-lin I have this test failing in my build on windows, is it flaky or an actual failure you reckon? |
Member
Author
|
@ThomasDelteil let me look into it |
Member
Author
|
It's a flaky one. I don't see it fail on master build. Maybe it's to do with param.load/save on windows... |
Contributor
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…am.save(). Fix trainer init_kvstore (apache#11266) * clip sparse grad. fix _reduce for rowsparse param * fix kvstore init for local kv * trigger
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
…am.save(). Fix trainer init_kvstore (apache#11266) * clip sparse grad. fix _reduce for rowsparse param * fix kvstore init for local kv * trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As title. Test cases are updated accordingly.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments