Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Enable support for dense weight and sparse grad Adagrad updates#11355

Merged
eric-haibin-lin merged 3 commits into
apache:masterfrom
leezu:DnsRspDnsAdagrad
Jun 25, 2018
Merged

Enable support for dense weight and sparse grad Adagrad updates#11355
eric-haibin-lin merged 3 commits into
apache:masterfrom
leezu:DnsRspDnsAdagrad

Conversation

@leezu
Copy link
Copy Markdown
Contributor

@leezu leezu commented Jun 21, 2018 •
edited
Loading

Description

As title. While the kernel was in place, the operator raised LogUnimplementedOp if called with dense weight and sparse gradient.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Enable dense weight, sparse grad updates with Adagrad

Comments

@eric-haibin-lin

@leezu leezu requested a review from szha as a code owner June 21, 2018 17:42
eric-haibin-lin
eric-haibin-lin reviewed Jun 21, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was just about to do this. Could you add a test in test_optimizer.py?

@leezu
Copy link
Copy Markdown
Contributor Author

leezu commented Jun 22, 2018

Added test.

@leezu leezu force-pushed the DnsRspDnsAdagrad branch from 72b778d to 0842c9b Compare June 22, 2018 16:41
@leezu leezu force-pushed the DnsRspDnsAdagrad branch from 0842c9b to 801d9f0 Compare June 22, 2018 16:42
@leezu
Copy link
Copy Markdown
Contributor Author

leezu commented Jun 22, 2018

Rebased to rerun tests

@szha
Copy link
Copy Markdown
Member

szha commented Jun 25, 2018

@eric-haibin-lin

@eric-haibin-lin eric-haibin-lin merged commit 9b27262 into apache:master Jun 25, 2018
@leezu leezu deleted the DnsRspDnsAdagrad branch June 25, 2018 16:46
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@leezu @eric-haibin-lin
Enable support for dense weight and sparse grad Adagrad updates (apac…
b2eb742 
…he#11355)

* Support dense weight and sparse grad AdagradUpdate

* Simplify AdagradStorageType

* Add test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@eric-haibin-lin eric-haibin-lin eric-haibin-lin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leezu @szha @eric-haibin-lin